Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose raw api call with context and raw context with headers #1068

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Expose raw api call with context and raw context with headers #1068

merged 3 commits into from
Aug 30, 2022

Conversation

23doors
Copy link
Contributor

@23doors 23doors commented Aug 29, 2022

Description

Simple change, .Raw() is already exposed so it makes sense to also expose version with context and with headers. Possibly also full context+headers+complete version should be included.

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

@23doors 23doors requested a review from jacobbednarz as a code owner August 29, 2022 23:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

changelog detected ✅

@23doors
Copy link
Contributor Author

23doors commented Aug 29, 2022

I think that due to relatively niche usage of .Raw, this change doesn't necessarily warrant a changelog entry. Added a temporary one though.

@jacobbednarz
Copy link
Member

given the low usage of this method, i would probably just update the method signature to include ctx and headers since i would imagine most would already want this. what do you think?

@23doors
Copy link
Contributor Author

23doors commented Aug 30, 2022

I agree and having just 1 signature for this is enough as long as it's not as limiting as the current one. For some it may be a backwards incompatible change though. But I guess it doesnt really matter for that kind of method.

Updated PR

@codecov-commenter
Copy link

Codecov Report

Merging #1068 (8917e44) into master (e39278e) will increase coverage by 0.09%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   49.94%   50.04%   +0.09%     
==========================================
  Files         115      116       +1     
  Lines       10991    11047      +56     
==========================================
+ Hits         5490     5528      +38     
- Misses       4338     4350      +12     
- Partials     1163     1169       +6
Impacted Files Coverage Δ
pages_project.go 50.81% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
api_shield.go 53.84% <53.84%> (ø)
workers.go 69.38% <72.72%> (-0.04%) ⬇️
cloudflare.go 68.42% <83.33%> (+1.21%) ⬆️
email_routing_settings.go 60.00% <100.00%> (ø)
images.go 50.34% <100.00%> (-0.35%) ⬇️
r2_bucket.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit aed1b76 into cloudflare:master Aug 30, 2022
@github-actions github-actions bot added this to the v0.49.0 milestone Aug 30, 2022
github-actions bot pushed a commit that referenced this pull request Aug 30, 2022
Update CHANGELOG.md for #1068
25c9b23
@github-actions
Copy link
Contributor

This functionality has been released in v0.49.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.49.0
Development

Successfully merging this pull request may close these issues.
3 participants
@23doors @jacobbednarz @codecov-commenter